<html><head><meta name="color-scheme" content="light dark"></head><body><pre style="word-wrap: break-word; white-space: pre-wrap;">
From: Mikael Pettersson &lt;mikpe@csd.uu.se&gt;

gcc-3.4.1 errors out in 2.6.8-rc1-mm1 at arch/i386/kernel/smp.c:

arch/i386/kernel/smp.c: In function `flush_tlb_others':
arch/i386/kernel/smp.c:161: sorry, unimplemented: inlining failed in call to 'send_IPI_mask_bitmask': function not considered for inlining
arch/i386/kernel/smp.c:9: sorry, unimplemented: called from here
make[1]: *** [arch/i386/kernel/smp.o] Error 1
make: *** [arch/i386/kernel] Error 2

The &lt;mach_ipi.h&gt; inlines depend on functions defined further down in smp.c.
 Moving the #include eliminates the problem.

Signed-off-by: Mikael Pettersson &lt;mikpe@csd.uu.se&gt;
Signed-off-by: Andrew Morton &lt;akpm@osdl.org&gt;
---

 25-akpm/arch/i386/kernel/smp.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)

diff -puN arch/i386/kernel/smp.c~arch-i386-kernel-smpc-gcc341-inlining-fix arch/i386/kernel/smp.c
--- 25/arch/i386/kernel/smp.c~arch-i386-kernel-smpc-gcc341-inlining-fix	2004-07-26 14:49:39.813859992 -0700
+++ 25-akpm/arch/i386/kernel/smp.c	2004-07-26 14:49:39.817859384 -0700
@@ -22,7 +22,6 @@
 
 #include &lt;asm/mtrr.h&gt;
 #include &lt;asm/tlbflush.h&gt;
-#include &lt;mach_ipi.h&gt;
 #include &lt;mach_apic.h&gt;
 
 /*
@@ -230,6 +229,8 @@ inline void send_IPI_mask_sequence(cpuma
 	local_irq_restore(flags);
 }
 
+#include &lt;mach_ipi.h&gt; /* must come after the send_IPI functions above for inlining */
+
 /*
  *	Smarter SMP flushing macros. 
  *		c/o Linus Torvalds.
_
</pre></body></html>